max-mapper/electron-spawn

Doesn’t work with whitespace in filename

Open

#13 opened on Dec 12, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (18 forks)github user discovery
help wanted

Repository metrics

Stars
 (196 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi, the JS API seems to have problems executing a file with whitespace in its path.

To reproduce:

▸ git clone git@gist.github.com:7fbe4fafe896bbb96679.git

▸ npm install

▸ node -e "require('electron-spawn')('no-space.js').stdout.pipe(process.stdout)"
◂ ok
# This is alright.

▸ node -e "require('electron-spawn')('with space.js').stdout.pipe(process.stdout)"
# The `ok` never comes!

The contents of no-space.js and with space.js are identical.

Contributor guide

Research direction
Investigate how the file path is passed to the child process. Ensure it is properly escaped or quoted to handle spaces. Consider using shell quoting functions or array based spawning to avoid shell interpretation.
Tech stack
javascriptnodejs
Domain
clibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsshell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75