matthewmueller/x-ray

Uncaught ECONNRESET exception

Open

#171 opened on Apr 9, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (5,804 stars) (415 forks)batch import
bughelp wanted

Description

Subject of the issue

I found that the following apparently uncaught exception occurred and crashed our Node process instead of being caught by x-ray and forwarded as an err:

events.js:154
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at exports._errnoException (util.js:890:11)
    at TCP.onread (net.js:552:26)

Your environment

node v5.9.1 npm v3.7.3

Steps to reproduce

Scrape from a source which resets the connection remotely.

Expected behaviour

Expected exception to be caught by x-ray and passed to callback as err.

Actual behaviour

Uncaught exception crashes process.

(PS many thanks for a great lib)

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js event handlingKnowledge of x ray library internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the x ray library's HTTP request handling to find where ECONNRESET errors are not caught. Look in the main driver file (likely index.js or driver.js) for where requests are made. Ensure that the error event on the response stream is properly handled and forwarded to the callback. The issue suggests that the error is emitted on the socket and not caught by x ray's promise or callback structure.