mattermost/mattermost

Inconsistent padding in the Enterprise Edition License modal

Open

#29,432 opened on Nov 29, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)TypeScript (7,823 forks)batch import
Help Wanted

Repository metrics

Stars
 (32,880 stars)
PR merge metrics
 (Avg merge 6d 5h) (318 merged PRs in 30d)

Description

Summary

There's no padding at the bottom of the EE license modal below the button. The space above the title is also fairly large.

Steps to reproduce

  1. Click the product switcher menu at the top left of the screen.
  2. Click the "System Console" option.
  3. Ensure "Edition and License" is selected in the sidebar.
  4. Click the "Enterprise Edition License" button that looks like a link to open the dialog box.

Operating System

macOS Monterey 12.7.6

Mattermost Server Version

Mattermost Version: dev Database Schema Version: 128 Build Number: n/a Database: postgres

Expected behavior

The modal has sufficient padding at the bottom consistent with the other modals.

Observed behavior

There's no padding at the bottom of the modal.

Log Output

N/A

Additional Information

enterprise-edition-license-modal-no-padding

Contributor guide

Research direction
Inspect the modal component in the codebase, likely in the 'components' directory, and add appropriate CSS padding to the Enterprise Edition License modal. Look for consistent padding values used in other modals.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75