mattermost/mattermost

The HTML tag always has lang="en" even if the language in settings is set to a different language

Open

#26672 opened on Apr 5, 2024

View on GitHub
 (26 comments) (2 reactions) (1 assignee)TypeScript (32,880 stars) (7,823 forks)batch import
Difficulty/1:EasyHelp WantedTech/ReactJS

Description

Original ticket: https://github.com/mattermost/mattermost-server/issues/21552

Summary

The html tag always defines the language of the page to <html lang="en">. We want this to be set to the “DefaultClientLocale”, that can be found in the config. If there is no value in the config, we can set it to unknown.

The objective of this is so browsers translate the content of the site (the messages in the posts) from the language the server is in theory using.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-48048

Contributor guide

Tech stack
typescriptreacthtml
Domain
frontendaccessibilityinternationalization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with React and HTML templatesunderstanding of Mattermost config structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is to dynamically set the lang attribute on the <html> tag based on the DefaultClientLocale from the Mattermost config. The current code always sets lang="en". To start, search for where the HTML template is rendered (likely in the server rendered index.html or root component). Then locate where the config (DefaultClientLocale) is accessible, possibly via the Redux store or initial state. Review comments in the issue for any suggested approach. Reference the original server ticket for backend context. Ensure fallback to 'unknown' if config value is missing.