mattermost/mattermost

Mobile web: Hamburger button is highlighted after selecting channel to switch to

Open

#26,265 opened on Feb 20, 2024

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (7,823 forks)batch import
Help Wanted

Repository metrics

Stars
 (32,880 stars)
PR merge metrics
 (Avg merge 6d 5h) (318 merged PRs in 30d)

Description

I'm only able to reproduce this on an actual mobile device. It doesn't seem to reproduce when using chrome dev tools.

Tapping the hamburger menu followed by tapping on a channel to navigate to makes it so the button is still highlighted (unwanted behavior). Tapping away after that makes it no longer highlighted.

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-35187

Contributor guide

Research direction
Investigate the CSS state of the hamburger button after navigation and ensure the active/highlighted state is cleared when navigating to a channel. Check for any CSS pseudo classes like :focus or :active that persist. Consider using a blur() method or resetting focus on route change.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScriptReactCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65