mattermost/mattermost

CPU usage of "Mattermost Helper" on Mac Desktop app spikes with animated GIFs in view on Mattermost

Open

#24,689 opened on Jul 25, 2016

View on GitHub
 (27 comments) (3 reactions) (0 assignees)TypeScript (32,880 stars) (7,823 forks)batch import
HacktoberfestHelp WantedUp For Grabs

Description

I confirm (by marking "x" in the [ ] below):

Jira ticket: https://mattermost.atlassian.net/browse/MM-14109

Summary

CPU usage of "Mattermost Helper" on Mac Desktop app spikes with animated GIFs in view on Mattermost

Steps to reproduce

On Mac OS X 10.10.5 using Mattermost Desktop app 1.2 and Mattermost server 3.2 (master) paste multiple animated GIFs in Mattermost channel and notice CPU utilization of "Mattermost Helper"

Expected behavior

CPU usage should not be extraordinarily high

Observed behavior

CPU usage can spike as high as 66% when animated GIFs are visible, but falls back to normal in channels without animated GIFs.

image

Possible fixes

If you can, link to the line of code that might be responsible for the problem.

Contributor guide

Tech stack
electrontypescript
Domain
desktopperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how the Mattermost desktop app renders animated GIFs. The issue likely stems from inefficient handling of animated images in the Electron webview. Review the rendering pipeline for images, especially any repaint loops or missing throttling. Check if the app uses a library like gif.js or native image handling. Look at comments in the issue for any attempted solutions. Consider using requestAnimationFrame to limit frame rate or pausing animation when not in view.