mattermost-community/mattermost-plugin-memes

Crash for some texts

Open

#48 opened on Apr 18, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Go (33 forks)auto 404
Difficulty/1:EasyGood First IssueHacktoberfestHelp WantedTech/GoType/BugUp For Grabs

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

Working: /meme brace-yourselves Its Sunday

Not working: /meme brace-yourselves It's Sunday

Result: "Internal Server Error" and the following log entry

{"level":"error","ts":1618726829.0428991,"caller":"mlog/log.go:232","msg":"error resolving meme","path":"/api/v4/commands/execute","request_id":"warwwuchztb978swhjfp7jey7e","ip_addr":"93.218.248.222","user_id":"f3c6mis46byi8mhj3bmfswbmrc","method":"POST","err_where":"ExecuteCommand","http_code":500,"err_details":"Unterminated single-quoted string"}

Mattermost 5.34.2 with NGINX

Contributor guide

Research direction
Inspect the command parsing logic to handle single quotes within arguments.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitGo
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70