mattermost-community/focalboard

Colors in Board Groups are too bright

Open

#5001 opened on Oct 18, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
HacktoberfestHelp WantedUp for grabs

Description

Summary

Custom theme used:

{
  "awayIndicator": "#eea941",
  "buttonBg": "#43b581",
  "buttonColor": "#ffffff",
  "centerChannelBg": "#36393e",
  "centerChannelColor": "#e6e6e6",
  "codeTheme": "monokai",
  "dndIndicator": "#b74b47",
  "errorTextColor": "#fd5960",
  "linkColor": "#88a7ff",
  "mentionBg": "#7289da",
  "mentionBj": "#ffffff",
  "mentionColor": "#dcddde",
  "mentionHighlightBg": "#36393e",
  "mentionHighlightLink": "#88a7ff",
  "newMessageSeparator": "#eea941",
  "onlineIndicator": "#64b285",
  "sidebarBg": "#2f3136",
  "sidebarHeaderBg": "#282b30",
  "sidebarHeaderTextColor": "#818386",
  "sidebarTeamBarBg": "#202226",
  "sidebarText": "#dbdbdb",
  "sidebarTextActiveBorder": "#35363c",
  "sidebarTextActiveColor": "#dcddde",
  "sidebarTextHoverBg": "#35363c",
  "sidebarUnreadText": "#f8f8f8"
}

Steps to reproduce

Mattermost version: 5.5.1 (63830002741) OS: macOS Sonoma 14.0

Whenever Boards are fresh opened in the app the colors are too bright. What resolves it though is saving again the same custom theme settings. And it works fine until Boards are reopened again.

Expected behavior

image

Observed behavior (that appears unintentional)

image

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactCSS in JS or theme contextReading existing theme code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is that when Boards is opened for the first time, the custom theme colors appear too bright, but re saving the theme fixes it. This suggests a race condition where the theme is not fully applied on initial load. Investigate the theme initialization flow in the source code, likely in files related to theme handling (e.g., `webapp/src/components/themeProvider.tsx` or similar). Look for any asynchronous loading of theme data that might cause the default colors to be used initially. Also check if there is a difference between the initial load and subsequent loads that reapply the theme correctly. The test should verify that the colors match the saved theme immediately on first open.