mattermost-community/focalboard

Bug: Empty cards are created when no changes are made

Open

#4843 opened on Sep 8, 2022

View on GitHub
 (31 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
EnhancementHacktoberfestHelp Wanted

Description

Steps to reproduce the behavior

  1. Click on the "+ New" button to make a new card
  2. Immediately close the modal without making any changes

Expected behavior

A card isn't created automatically unless the user enters some text or makes some changes. It feels too easy to accidentally create cards that you didn't mean to.

Screenshots (optional)

Screen Shot 2022-09-08 at 11 32 24 AM

Edition and Platform

  • Edition: Mattermost Boards on community.mattermost.com
  • Version: v7.2.1

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Reactstate managementmodal component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the component responsible for the '+ New' button and the modal. Look for where the card creation is triggered on modal close. Determine if there is a condition to check for changes before creating. The solution likely involves adding a check for user input or changes before dispatching the create action. Consider using the modal's onClose event to validate changed state.