mattermost-community/focalboard

Bug: ctrl+Z doesn't always undo

Open

#4841 opened on Oct 18, 2022

View on GitHub
 (2 comments) (0 reactions) (1 assignee)TypeScript (26,187 stars) (2,542 forks)user submission
HacktoberfestHelp Wanted

Description

Steps to reproduce the behavior

  1. Go to focalboard
  2. Open a card
  3. Type a comment
  4. Delete a single character with backspace
  5. Press ctrl+Z

Expected behavior

I expect ctrl+Z to restore the character i deleted. Instead, nothing happens.

Edition and Platform

  • Edition: the one on the community server, as of today
  • Version: v7.4.2
  • Browser and OS: both on Firefox 105.0.3, and on the Mattermost desktop client. OS is Ubuntu 22.04

Additional context

This is Sev 3 (minor, non-critical functionality), but it can become a bit frustrating when typing long comments in particular. E.g. something gets deleted by mistake, and it cannot be restored in any way. I am currently typing my comments on a text editor first, then copypasting them into the card, in order to avoid running into this issue again.

A few cases in which ctrl+Z didn't work:

  • Type a comment -> delete single character -> press ctrl+Z (it should restore the deleted character, but doesn't)
  • Type a comment -> press ctrl+backspace to delete the last word -> press ctrl+Z (it should restore the deleted word, but doesn't)
  • Type a comment -> press ctrl+Z (should delete the last word or letter that was typed, but doesn't)

Interestingly, there's also a case in which ctrl+Z worked well:

  • Type a comment -> select it all with ctrl+A -> press backspace to delete it -> press ctrl+Z (it successfully restores the full deleted comment, as expected)

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React/TypeScript knowledgeUnderstanding of undo/redo stacksFamiliarity with focalboard's comment editor code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the comment editor component in focalboard, likely located in the webapp/src/components/ directory. Look for undo/redo logic, possibly implemented via a custom hook or a history stack. Examine how textarea input events are handled and how ctrl+Z is intercepted. Check if the undo functionality only works for certain actions (e.g., full content replacement) but fails for character level edits. Consider reviewing the relevant source file and any existing tests for undo behavior.