mattermost-community/focalboard

Bug: Giving and removing access for boards and templates behaves incorrectly

Open

#4836 opened on Dec 14, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
Help WantedSev/3Up for grabs

Description

Steps to reproduce the behavior

  1. Login to Boards as User A and open a board (i.e., Board 123)
  2. Go the the Share dialog and add User B to Board 123 as any role
  3. In a separate incognito browser, login as User B and go to Board 123
  4. Go back to the window with User A and remove User B from the board
  5. Go to window with User B and see error - user is taken to the template picker
  6. As User A, add User B back to Board 123
  7. Go to window with User B again and see error - Board 123 is automatically opened for User B after User A added them back to the board
  8. Repeat steps 1-7 on the template editor and see the same issue there as well.

Expected behavior

Step 5: When a user is removed from a board, and they have other boards in their sidebar, they should be taken to the next available board on the sidebar. Step 7: The board should be added back to User B's sidebar, but NOT automatically open for them. User B should remain on their current view.

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: 7.7.0
  • Browser and OS: Chrome on Mac

Screenshots (optional)

https://www.loom.com/share/8be49d3ea4b34b4283860cffe3bd0e7d

Contributor guide

Tech stack
typescriptreact
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React and TypeScriptFamiliarity with board sharing permissions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the logic for adding/removing users from boards, particularly in the Share dialog component. Check how the frontend handles real time updates when a user is removed or added to a board, focusing on the sidebar state and automatic navigation. Look at the board store and websocket events. The bug seems related to incorrect navigation and automatic opening of boards. Consider files like webapp/src/components/shareBoard and webapp/src/store/boards.