mattermost-community/focalboard

Bug: Ctrl+Shift to select multiple cards also selects unrelated cards

Open

#4835 opened on Mar 14, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
Help WantedUp for grabs

Description

Steps to reproduce the behavior

  1. Open a Kanban view with multiple cards in multiple columns.
  2. Hold Shift to select a card.
  3. Hold Ctrl+Shift to select a different card in the same column.
  4. Cards between the 2 selected cards are selected. But also cards in other columns.

Expected behavior

The first card, the second card and any cards in between should be selected. No other cards should be selected, only cards in between.

Screenshots (optional)

In the screenshot 2 cards are highlighted with a red border to show the cards that were clicked on. 2 cards in between are selected, as well as 3 cards in other columns. image

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: cloud-2023-01-16-1
  • Browser and OS: Mattermost desktop app on Windows 10

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptevent handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Start by examining the card selection logic in the board components, particularly how shift+click and control+click events are handled. Look for files like 'kanbanBoard.tsx' or similar that manage selection state. Check if there are existing tests for selection behavior. The issue mentions unexpected selection of cards across columns, so focus on the logic that determines the range of selected cards.