mattermost-community/focalboard

Boards: try to attach image to card without permission shows wrong error msg

Open

#4834 opened on Mar 30, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
Help WantedUp for grabs

Description

Summary

When viewing a card where you only have commenter permissions and trying to attach an image, the error message indicates the file size is too large (it isn't) instead of stating that you don't have permission.

Steps to reproduce

See screen shot

Expected behavior

Error message should state you do not have permission to attach a file.

Observed behavior (that appears unintentional)

attach_file_without_permissions

Contributor guide

Tech stack
typescriptreact
Domain
frontendauthorization
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Reactfamiliarity with Focalboard's permission model
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the file upload component in the webapp directory, likely under webapp/src/components/cardDetail. Look for the error handling logic that checks file size vs permissions. The fix involves showing the correct permission error message instead of the file size message when the user lacks permissions. Check any existing permission utilities or hooks to understand how user permissions are validated.