mattermost-community/focalboard

Boards: JS errors when adding blank lines to a new comment on a card and navigating with cursors keys

Open

#4,831 opened on May 9, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,542 forks)user submission
Help Wanted

Repository metrics

Stars
 (26,187 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary

TypeError: Cannot read properties of undefined (reading 'getText')

Steps to reproduce

Mattermost Team Edition 7.8.3 with Boards 7.10.0 Desktop client 5.3.1 on Windows 10

  1. Open an existing card on a board
  2. Click in the field to add a comment
  3. Hit Shift+Enter twice
  4. Navigate up twice using the up-arrow key

Observed behavior (that appears unintentional)

The red "A JavaScript error has occurred" banner appears, but the UI continues to function normally. See attached log - both MatterPoll and Boards throw the error.

boards.log

Contributor guide

Research direction
Investigate the comment input handler for cursor key events and ensure getText is called on a defined object. Look for undefined references in the editor state when blank lines are inserted.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60