mattermost-community/focalboard

Boards: JS errors when adding blank lines to a new comment on a card and navigating with cursors keys

Open

#4831 opened on May 9, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
Help Wanted

Description

Summary

TypeError: Cannot read properties of undefined (reading 'getText')

Steps to reproduce

Mattermost Team Edition 7.8.3 with Boards 7.10.0 Desktop client 5.3.1 on Windows 10

  1. Open an existing card on a board
  2. Click in the field to add a comment
  3. Hit Shift+Enter twice
  4. Navigate up twice using the up-arrow key

Observed behavior (that appears unintentional)

The red "A JavaScript error has occurred" banner appears, but the UI continues to function normally. See attached log - both MatterPoll and Boards throw the error.

boards.log

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptFocalboard codebase navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The error occurs in the comment editor when navigating with cursor keys after inserting blank lines. Investigate the comment input component in the webapp directory, likely where 'getText' is called on an undefined object. Ensure null checks are added before accessing 'getText'. The attached log may provide additional context.