mattermost-community/focalboard

API Integration Tests - ./api/api.go (Files API)

Open

#437 opened on May 17, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
Good First IssueHacktoberfestHelp WantedUp for grabs

Description

Add integration tests for missing File API endpoints

files := r.PathPrefix("/files").Subrouter()
files.HandleFunc("/workspaces/{workspaceID}/{rootID}/{filename}", a.attachSession(a.handleServeFile, false)).Methods("GET")

These are currently in the ./src/octoClient.ts class, so test should go in ./src/octoClient.test.ts see ./integrationtests/blocks_test.go and sharing_test.go for samples.

Contributor guide

Tech stack
gotypescript
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go testingTypeScriptIntegration test patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Review the existing integration tests in ./integrationtests/blocks test.go and sharing test.go to understand the testing patterns. Then add tests for the File API endpoints in ./api/api.go by creating a new test file or adding to an existing test suite. The tests should cover the GET /files/workspaces/{workspaceID}/{rootID}/{filename} endpoint, mirroring the pattern from the referenced tests.