mattermost-community/focalboard

Permissions Branch: No padding below modal menus

Open

#2,715 opened on Apr 1, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHelp WantedSev/3Tech/ReactUp for grabs

Description

Steps to reproduce the behavior

Related to #2714

Share Modal

  1. Go to share modal
  2. Go to the last visible member of the board and change their role
  3. Scroll to bottom of role selector menu
  4. See error - there is no padding below the menu

Card View Modal

  1. Go to card view modal
  2. Create a select or multi-select property
  3. Add 10+ values for the property (enough so when the menu is expanded, it reaches to the bottom of the card view modal)
  4. Select the property field to assign a value
  5. Scroll to bottom of the menu
  6. See error - there is no padding below the menu

Expected behavior

Should be some padding below the menu

Screenshots (optional)

Screen Shot 2022-04-01 at 2 58 49 PM

Screen Shot 2022-04-01 at 3 04 19 PM

Edition and Platform

  • Edition: Mattermost Boards (plugin)
  • Version: permissions-feature-branch
  • Browser and OS: Chrome on Mac

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSReact basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the share modal and card view modal components in the webapp directory. Look for the menu component that lists board members and property values. Add padding bottom to the menu container element, likely via a CSS class. Check if there is an existing style for scrollable menus that needs adjustment. The screenshots show the menu touching the bottom edge, so applying padding bottom: 8px or similar should fix it.