mattermost-community/focalboard

Bug: Accessibility > Ensure buttons have discernible text

Open

#2,191 opened on Jan 27, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHelp Wanted

Description

Ensure that each button element and elements with role="button" have one of the following characteristics (more info):

  • Inner text that is discernible to screen reader users.
  • Non-empty aria-label attribute.
  • aria-labelledby pointing to element with text which is discernible to screen reader users.
  • role="presentation" or role="none" (ARIA 1.1) and is not in tab order (tabindex="-1")

List of buttons:

  1. Sidebar 1

    • Element location: .\' > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><svg xmlns="http://www.w3.org/2000/svg" class="DisclosureTriangleIcon Icon" viewBox="0 0 100 100"><polygon points="37,35 37,65 63,50"></polygon></svg></button>

  2. Sidebar 2

    • Element location: .\' > .MenuWrapper[role="button"][aria-label="menuwrapper"] > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><i class="CompassIcon icon-dots-horizontal OptionsIcon"></i></button>

  3. Header 1

    • Element location: .MenuWrapper[role="button"][aria-label="menuwrapper"]:nth-child(2) > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><i class="CompassIcon icon-chevron-down DropdownIcon"></i></button>

  4. Header 2

    • Element location: .ModalWrapper:nth-child(9) > .MenuWrapper[role="button"][aria-label="menuwrapper"] > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><i class="CompassIcon icon-dots-horizontal OptionsIcon"></i></button>

  5. Board view 1

    • Element location: .KanbanColumnHeader.octo-board-header-cell[draggable="true"]:nth-child(1) > .MenuWrapper[role="button"][aria-label="menuwrapper"] > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><i class="CompassIcon icon-dots-horizontal OptionsIcon"></i></button>

  6. Board view 2

    • Element location: .KanbanColumnHeader.octo-board-header-cell[draggable="true"]:nth-child(1) > .IconButton.Button[type="button"]
    • Element source: <button type="button" class="Button IconButton"><i class="CompassIcon icon-plus AddIcon"></i></button>

  7. Card view

    • Element location: .MenuWrapper[aria-label="menuwrapper"][role="button"] > .IconButton--large.IconButton.Button
    • Element source: <button type="button" class="Button IconButton IconButton--large"><i class="CompassIcon icon-dots-horizontal OptionsIcon"></i></button>

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontendaccessibility
Issue type
accessibility
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic HTML/CSS knowledgeUnderstanding of ARIA attributesFamiliarity with React components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue lists specific buttons in the UI that lack discernible text. Review the components referenced (e.g., IconButton, MenuWrapper) in the codebase, likely under webapp/src/components. Add appropriate aria label attributes to each button element as described. No linked PRs or assignees exist, so this is available for a newcomer. Check comments for any additional guidance from maintainers.
Bug: Accessibility > Ensure buttons have discernible text · mattermost-community/focalboard#2191 | Good First Issue