mattermost-community/focalboard

Bug: Date picker - clicking "today" multiple times when date range is set clears the date

Open

#2,065 opened on Jan 7, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHelp WantedUp for grabs

Description

Steps to reproduce the behavior

  1. Open a card
  2. Create a date property and edit it
  3. Select a date
  4. Enable "Date range" and select an end date
  5. Click on the "today" button - it sets start date to today
  6. Click "today" again - it sets the end date to today
  7. Click "today" again - it clears the date
  8. Click "today" again - it re-sets the date to just today, without a range

Expected behavior

Clicking "today" the third time should not clear the date.

Screenshots

https://user-images.githubusercontent.com/46905241/148566850-962820c6-14d3-422c-8223-8bdcfa259b5e.mov

Edition and Platform

  • Edition: Mattermost plugin
  • Version: v0.12 RC1
  • Browser and OS: Mac Chrome

Additional context

If only a single date is selected to begin with, clicking "today" multiple times does not clear the picker.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The bug is in the date picker component, specifically the logic for the 'today' button when a date range is enabled. The expected behavior likely involves setting both start and end dates to today or toggling the range. Look at the date picker source files (e.g., `webapp/src/components/datePicker/DateRange.tsx` or `Calendar.tsx`). Verify the current behavior by tracing the click handler for the 'today' button. The issue has no comments or PRs, so the fix is open for contribution.