mattermost-community/focalboard

Bug: Card View Select Type does not trim spaces

Open

#1,921 opened on Dec 3, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHelp Wanted

Description

Steps to reproduce the behavior

  1. Go to Card View
  2. Select a "Select' Property.
  3. Type an existing property name...then add a space.
  4. Note that the new select value is allowed to be created allowing two values that look the same.

Note this will apply to values that have an icon as well.

Expected behavior

We should trim spaces before adding a new select value

Screen shot

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Locate the Select component in the Focalboard codebase (likely in webapp/src/components). Find the handler that creates a new select option when typing. Add a call to .trim() on the input value before adding it. Check if similar trimming is needed for icon related values. Test the fix manually.