mattermost-community/focalboard

Cannot add Japanese text into status label

Open

#144 opened on Mar 20, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (26,187 stars) (2,542 forks)user submission
BugHacktoberfestHelp WantedUp for grabs

Description

Summary:

  • Typing some Japanese text into status labels does not work, treated just like nothing was typed.
  • Pasting such text always work as intended.
  • When the label text is empty, typed text shows up

Steps to reproduce the behavior:

  1. Create a status (NEW GROUP already input)
  2. Type some Japanese text into label, with IME
  3. Nothing will show up
  4. Paste such text into label (e.g. 貼り付け)
  5. It works
  6. Delete all text in label, unfocus and refocus label area
  7. Type some Japanese text
  8. It will show up

Expected behavior: Whether IME are enabled or not, and whatever text set in label, typed text will show up.

Screenshots: Reproducing steps:

https://user-images.githubusercontent.com/2630080/111861567-a6b45a00-8992-11eb-8eca-7a26543c4dd6.mp4

Platform:

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactUnderstanding of IME composition events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the label input component in Focalboard, likely found in 'webapp/src/components/statusLabel.tsx' or similar. The issue likely stems from missing handling of 'compositionstart', 'compositionupdate', and 'compositionend' events on the input field. Check if there's an 'onInput' or 'onChange' handler that ignores text during IME composition. Look at the linked PRs or comments for any attempted fixes. Test with different IMEs and browsers.
Cannot add Japanese text into status label · mattermost-community/focalboard#144 | Good First Issue