mattdesl/budo

Should LiveReload be injected into HTML imports?

Open

#119 opened on Dec 17, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (2,174 stars) (124 forks)batch import
bughelp wanted

Description

If I have an HTML import (<link rel="import" href="import.html">), the Live Reload <script> gets injected there, as well as in the parent document. In the case of nested imports, this can get hairy. Not sure whether the scripts should be injected in imports.

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
HTML importsLiveReload injection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the LiveReload injection mechanism in budo, specifically the logic that injects scripts into HTML files. Determine whether HTML imports should be excluded from injection. Check the comment in the issue for any direction. The relevant code likely resides in the server side scripts.