mattdesl/budo

Should LiveReload be injected into HTML imports?

Open

#119 opened on Dec 17, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (124 forks)batch import
bughelp wanted

Repository metrics

Stars
 (2,174 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I have an HTML import (<link rel="import" href="import.html">), the Live Reload <script> gets injected there, as well as in the parent document. In the case of nested imports, this can get hairy. Not sure whether the scripts should be injected in imports.

Contributor guide

Research direction
Inspect the injection logic in budo's middleware to determine if HTML imports should be excluded from LiveReload script injection.
Tech stack
javascript
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HTMLJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75