matrix-org/synapse

Fix remaining uses of deprecated cmp argument in attrs decorators

Open

#9,641 opened on Mar 17, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (2,196 forks)batch import
O-UncommonS-TolerableT-Taskgood first issue

Repository metrics

Stars
 (11,713 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

There are a handful of places left that use the deprecated cmp argument on the attr.s decorator:

These should be fixed.

Contributor guide

Research direction
Replace the deprecated cmp argument with the new equivalent (e.g., eq=True, order=True) in the four files listed in the issue description.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonattrs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70