matrix-org/synapse

Third Party Lookups: the returned protocol instance icons are not Matrix Content URIs

Open

#4,175 opened on Nov 12, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (11,713 stars) (2,196 forks)batch import
A-Spec-ComplianceS-MinorT-Defectgood first issue

Description

Contrary to the documentation (https://matrix.org/docs/spec/client_server/r0.4.0.html#get-matrix-client-r0-thirdparty-protocols), the returned protocol icons are not mxc:// URIs. The client gets https URLs (like "https://matrix.org/_matrix/media/v1/download/matrix.org/DHLHpDDgWNNejFmrewvwEAHX").

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic PythonUnderstanding of Matrix spec
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue describes that protocol instance icons are returned as https URLs instead of mxc:// URIs. To fix, locate the code in Synapse that handles third party protocol lookups (likely in synapse/rest/thirdparty.py or similar). Ensure that when returning protocol instance icons, the URI is an mxc:// URI as per the Matrix specification. This may involve converting the media URL to an MXC URI using the appropriate media repository API. No linked PRs exist, so the fix is independent.