matrix-org/synapse

audit M_UNKNOWN errors and make them meaningful - eg 'you are not invited' (SYN-422)

Open

#1338 opened on Jun 17, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (11,713 stars) (2,196 forks)batch import
O-UncommonS-TolerableT-Enhancementgood first issue

Description

Submitted by @​matthew:matrix.org

(Imported from https://matrix.org/jira/browse/SYN-422)

Contributor guide

Tech stack
python
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Pythonfamiliarity with Matrix protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Synapse source code, especially the error handling module (likely in synapse/errors.py or similar), to identify all places where M UNKNOWN is used. Review the Matrix specification for proper error codes and messages. Propose changes to replace M UNKNOWN with specific error codes (e.g., M FORBIDDEN for 'you are not invited') and update corresponding test cases. Check existing comments in the issue for any prior discussion or partial work.