matrix-org/synapse

AttributeError: 'str' object has no attribute 'items'

Open

#10,376 opened on Jul 12, 2021

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Python (11,713 stars) (2,196 forks)batch import
S-MinorT-Defectgood first issue

Description

2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO Failed to handle edu 'm.receipt'
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO Traceback (most recent call last):                              
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO   File "/nix/store/08q3wjbab0kqaa3qr0nhamdhzkjcy6pb-matrix-synapse-1.37.1/lib/python3.8/site-packages/synapse/federation/federation_server.py", line 1118, in on_edu                                                                                                                                  
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO     await handler(origin, content)                                                                 
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO   File "/nix/store/08q3wjbab0kqaa3qr0nhamdhzkjcy6pb-matrix-synapse-1.37.1/lib/python3.8/site-packages/synapse/handlers/receipts.py", line 62, in _received_remote_receipt                                                                                                                             
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO     for receipt_type, users in room_values.items():                                                     
2021-07-12T11:46:22.104 2587790268211 matrix-synapse.service homeserver[2934508] INFO AttributeError: 'str' object has no attribute 'items'

Synapse 1.37.1, nixos 21.05, linux x86_64

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonunderstanding of Matrix federation EDUs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The error occurs in synapse/handlers/receipts.py at line 62 where `content` is expected to be a dict but is a string. The traceback shows that `on edu` in federation server.py passes `content` to the handler. Investigate the caller in federation server.py around line 1118 to understand what `content` is. Likely the issue is that the EDU content is parsed incorrectly, or a missing validation. Check if there are any previous fixes or comments in the issue for hints.