There are no tests to ensure that floats fail
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 38/100
Research direction
Start by locating the number serialization and existing test suite in the repository, then trace how numeric values are handled. Add regression coverage for floats and the specified integer range, and run the full test suite to confirm invalid numbers fail without breaking supported canonical JSON.
Written by the indexing model from the issue text.
Description
As per spec:
Numbers in the JSON must be integers in the range
[-(2**53)+1, (2**53)-1].
There isn't any code that checks for floats, either.
- Dominant language
- Python
- Stars
- 30
- Forks
- 15
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from matrix-org/python-canonicaljson
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
JSON is RFC8259 Open
Difficulty 1/5 Under an hour Newbie friendliness 45/100
All issues in matrix-org/python-canonicaljson
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100