Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

FCP can be started again after one had successfully completed

Open
#32 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
devtools

Research direction

Start by locating the FCP comment edit handling in mscbot and inspect how the proposed-final-comment-period label is checked. Reproduce the case where a completed FCP comment is edited, then verify that the edit does not start another FCP when the label is absent.

Written by the indexing model from the issue text.

Description

bug

For instance, after an FCP merge is successful and the proposal is accepted, if a user edits the latest FCP proposal comment and there's enough votes, mscbot will start FCP again. (Example).

A fix here would be to ignore edits to FCP comments if the proposed-final-comment-period label is not present.

Dominant language
Python
Stars
7
Forks
2
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/mscbot-python

All issues in matrix-org/mscbot-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.