mscbot may not start FCP when using `@mscbot reviewed`

Open
#19 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
50/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start in command_handler.py around lines 169–172 and trace the reviewed command's handling of the ongoing FCP status comment. Ensure the bot's status-comment update is processed so that FCP starts when enough ticks have occurred, then verify the behavior with the project's relevant tests.

Written by the indexing model from the issue text.

Description

bug

One can use @mscbot reviewed to automatically check the box for themselves in an ongoing FCP status comment. The bot will also unconditionally ignore all comments and comment edits from itself.

When designing the reviewed command, it was incorrectly assumed that updating the status comment would then have the knock-on effect of starting FCP if enough ticks had happened. Instead, the edit is ignored as it comes from the bot.

A fix would simply involve manually calling _process_status_comment_update_with_body below https://github.com/matrix-org/mscbot-python/blob/fd6027708fd6ce08767556689470a6759c8af4ef/command_handler.py#L169-L172

Dominant language
Python
Stars
7
Forks
2
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matrix-org/mscbot-python

All issues in matrix-org/mscbot-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.