Plugin changes authentication in http requests to local files

Open
#53 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
jupyter, jupyter-notebook

Research direction

Start with the linked jupyterlab_bokeh and Altair issues, then reproduce the local /files/... request with ipympl installed and absent. Trace why the request loses cookies and receives a 302 redirect to /login; done means local-file requests retain the expected cookies and no longer redirect unexpectedly.

Written by the indexing model from the issue text.

Description

I've run into this via https://github.com/bokeh/jupyterlab_bokeh/issues/42 and https://github.com/altair-viz/altair/issues/927.

When ipympl is installed, http requests to local files (GET /files/...) made by the vega plugin stop working. They get forwarded to /login with a 302 status code. Installing ipympl seems to cause the requests to be sent without any cookies. In my case requests without ipympl present had cookie data _xsrf, csrftoken, username-localhost-8888, username-localhost-8889.

Dominant language
Jupyter Notebook
Stars
1.7k
Forks
234
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matplotlib/ipympl

All issues in matplotlib/ipympl

Similar issues

More Security issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.