[BUG] Click and Button Presses don't work on Windows CI with `pympl` dependency

Open
#480 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
jupyter-notebook
Domain
ci-cd, testing-qa

Research direction

Start with the failed Windows CI in pull request #10913 and identify the 22 tests that simulate matplotlib clicks and key presses. Compare runs before and after adding ipympl to the dependencies, then determine what change makes those tests pass on Windows with the dependency present.

Written by the indexing model from the issue text.

Description

If someone had just a moment, it would be tremendously helpful to get some feedback about the failed CIs here https://github.com/mne-tools/mne-python/pull/10913. Basically, the tests that use fake clicking and key presses with matplotlib fail when ipympl is added as a dependency but only on Windows. I've checked and they pass locally on MacOS as well as on the CIs. Is there some global variable or setting that ipympl might be modifying and maybe we could change it back? The difference between all the 22 tests failing and all the tests passing was just adding ipympl to the dependencies list, it was run before and after adding those. Thanks!

Dominant language
Jupyter Notebook
Stars
1.7k
Forks
234
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from matplotlib/ipympl

All issues in matplotlib/ipympl

Similar issues

More DevOps issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.