matomo-org/matomo

E-Mail addresses with special characters are not working

Open

#11,796 opened on Jun 15, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (2,847 forks)batch import
BugHelp wanted

Repository metrics

Stars
 (21,513 stars)
PR merge metrics
 (Avg merge 8d 11h) (106 merged PRs in 30d)

Description

If one tries to add a new user with the email address john's.email@example.com piwik returns The email doesn't have a valid format. even though the address is perfectly valid. A var_dump($emailAddress) in this line shows that the all special characters get converted to HTML entities.

  • john's.email@example.com => john's.email@example.com
  • "very.unusual.@.unusual.com"@example.com => "very.unusual.@.unusual.com"@example.com
  • !#$%&'*+-/=?^_{|}~@example.com => !#$%&'*+-/=?^_{|}~@example.com

Contributor guide

Research direction
Inspect the email validation logic in core/Piwik.php around line 573 to understand why HTML entities are being encoded before validation. Check if sanitization is applied too early and suggest a fix to validate before encoding.
Tech stack
php
Domain
backendanalytics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPemail validation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80