matomo-org/matomo

E-Mail addresses with special characters are not working

Open

#11,796 opened on Jun 15, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)PHP (21,513 stars) (2,847 forks)batch import
BugHelp wanted

Description

If one tries to add a new user with the email address john's.email@example.com piwik returns The email doesn't have a valid format. even though the address is perfectly valid. A var_dump($emailAddress) in this line shows that the all special characters get converted to HTML entities.

  • john's.email@example.com => john's.email@example.com
  • "very.unusual.@.unusual.com"@example.com => "very.unusual.@.unusual.com"@example.com
  • !#$%&'*+-/=?^_{|}~@example.com => !#$%&'*+-/=?^_{|}~@example.com

Contributor guide

Tech stack
None
Domain
backendauthentication
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHP basicsEmail validation conceptsFamiliarity with Matomo core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the email validation in Piwik.php around line 573. The issue shows that special characters are HTML encoded before validation, causing rejection. Determine if the encoding is necessary for other purposes. Consider decoding the email address before validation or validating the raw input. Check the email validation function and ensure compliance with RFC 5321/5322. No linked PRs or recent comments; the issue may still be open.
E-Mail addresses with special characters are not working · matomo-org/matomo#11796 | Good First Issue