material-components/material-components-android

[BottomNavigationView] BottomNavigationView can have only one setOnNavigationItemSelectedListener

Open

#735 opened on Nov 5, 2019

View on GitHub
 (3 comments) (8 reactions) (0 assignees)Java (3,023 forks)batch import
Good First IssueWidget: BottomNavigationfeature request

Repository metrics

Stars
 (15,910 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

FEATURE REQUEST

As per title, BottomNavigationView can have only one setOnNavigationItemSelectedListener. This is annoying because if i use the bottomNavigationView.setupWithNavController(navController) this internally sets that listener, and i cannot use it anymore for anything else (like setting the text in a custom appBar, for example) A list of listeners would be the right thing in my opinion.

Ps. this probably applies to setOnNavigationItemReselectedListener(BottomNavigationView.OnNavigationItemReselectedListener listener) too.

For Pattern reference, see NavController addOnDestinationChangedListener and removeOnDestinationChangedListener

Contributor guide

Research direction
Investigate how other components like NavController implement multiple listeners (e.g., addOnDestinationChangedListener). Look at the current BottomNavigationView implementation and propose adding a list of OnNavigationItemSelectedListener.
Tech stack
javaandroid
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70