matcornic/hugo-theme-learn

Check perfect-scrollbar is used correctly

Open

#258 opened on Apr 1, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)HTML (1,575 stars) (1,427 forks)batch import
bughelp wanted

Description

( cc @ozobi )

There are two static JS files relating to perfect scrollbar

./static/js/perfect-scrollbar.min.js
./static/js/perfect-scrollbar.jquery.min.js

Are these duplicated files or do they serve different purposes? Additionally, I can't see the instantiation of the library anywhere

Looking for any mention of new PerfectScrollbar.

Can either the duplicate file get removed, or can we remove it completely if it's unused?

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Search the codebase for any instantiation of PerfectScrollbar using 'new PerfectScrollbar'. Also compare the two files `./static/js/perfect scrollbar.min.js` and `./static/js/perfect scrollbar.jquery.min.js` to see if they are identical. If no usage found and files are duplicates, remove the duplicate file or both if unused. If they are different, keep the necessary one.