mason-org/mason.nvim

[New package]: Home Assistant

Open

#1,257 opened on Apr 24, 2023

View on GitHub
 (1 comment) (2 reactions) (0 assignees)Lua (337 forks)batch import
help wantednew-package-request

Repository metrics

Stars
 (10,278 stars)
PR merge metrics
 (Avg merge 7d 18h) (4 merged PRs in 30d)

Description

I've searched open & closed issues for similar requests

Yes

Package name

home-assistant-language-server

Package homepage

https://github.com/keesschollaart81/vscode-home-assistant/tree/dev/src/language-service

Languages

YAML

How is this package distributed?

This is more of a request for help than a request for a package. I would like to add this package to the Mason registry but I'm not sure how to do it. Unlike the typescript-language-server home-assistant-language-server doesn't have a bin field in the package.json. I couldn't find documentation on what exactly npm:typescript-language-server does, but I assume it's at some point calling executing this binary using npm.

As mentioned home-assistant-language-server doesn't have a bin configured in it's package.json so I assume the same wouldn't work. So what would work? Should I write a wrapper like https://github.com/mason-org/r-languageserver or should I make a PR so that home-assistant-language-server does have a bin field?

If I do find a solution; how do I know it works before I open a PR to mason-registry? I can see that there is a lint script but is there also a way to test that I can install using the configuration I'm about to contribute? Can I add my local checkout of mason-registry as a registry for example?

For what it's worth I have the home-assistant-language server working using https://gist.github.com/pstuifzand/6efa1bac4618252d9e44297c36c0ef77 but I'd much rather have it working the same way all my other LSPs are setup.

Contributor guide

Research direction
Explore how to add a package to Mason registry when the npm package lacks a 'bin' field. Look at existing packages like r languageserver that use wrappers, and consider contributing a wrapper or a PR to add a 'bin' field upstream. Test locally by symlinking your local registry checkout.
Tech stack
luajavascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
LuaNeovimnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70