Easy fix for apps targeting Android 12

Open Beginner friendly
#144 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
android, java
Domain
mobile

Research direction

Start by locating the Android manifest declaration for com.github.moduth.blockcanary.ui.DisplayActivity and review how the library packages it. Check the Android 12 requirement described in the issue, then build the library or a sample app targeting Android 12. Done means the target build succeeds without the exported-attribute error and the activity declaration remains valid.

Written by the indexing model from the issue text.

Description

Library breaks build when targeting Android 12

Please add

               android:exported="false"

to "com.github.moduth.blockcanary.ui.DisplayActivity"

Or recommend users to add

        <activity android:name="com.github.moduth.blockcanary.ui.DisplayActivity"
                android:exported="false" />

to their AndroidManifest.xml

See: https://cafonsomota.medium.com/android-12-dont-forget-to-set-android-exported-on-your-activities-services-and-receivers-3bee33f37beb

Dominant language
Java
Stars
6.7k
Forks
1k
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from markzhai/AndroidPerformanceMonitor

All issues in markzhai/AndroidPerformanceMonitor

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.