markmarijnissen/cordova-app-loader

Basic Auth

Open

#38 opened on Apr 24, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (656 stars) (137 forks)batch import
enhancementhelp wanted

Description

URLS with basic auth. are not working right

like https://username:password@domain/mainfest.json

Found one issue in the bootstrap.js xhr.setRequestHeader("Authorization", "Basic ...);

is missing.

Also the cordova file loader does not set the right headers for downloading

authHeaderValue = function(username, password) {
    var tok = username + ':' + password;
    var hash = btoa(tok);
    return "Basic " + hash;
};

options.headers = {'Authorization': authHeaderValue('Bob', '1234') };

Contributor guide

Tech stack
javascript
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptCordova app structureHTTP basic auth
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the bootstrap.js file mentioned in the issue to locate where XHR requests are made and add 'Authorization' header with Basic auth token. Also examine the Cordova file loader to ensure headers are set during file downloads. The issue includes a code snippet for encoding credentials, so integrate that into both locations. Look at any existing linked PRs or comments for additional context, but none are present.