v1.1.0 appears to be a breaking change
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 30/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- go
- Domain
- backend-api-design
Research direction
Start by inspecting the safe.Run API and compare its current callback signature with the call shown in packr.go at the linked location. Check how the v1.1.0 change affects callers that provide func() callbacks. Done means the reported transitive dependency call is compatible again, with coverage for the affected behavior if the repository provides tests.
Written by the indexing model from the issue text.
Description
We are seeing CI failures in some private repositories that pull in this repo as a transitive dependency (due to it being used in github.com/gobuffalo/packr). The issue appears to be that the safe.Run now requires a func() error instead of just func(). You can see how it's being called here - https://github.com/gobuffalo/packr/blob/master/packr.go#L14.
- Dominant language
- Go
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from markbates/safe
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
kind/bug needs-triage
Difficulty 1/5 Under an hour Newbie friendliness 72/100
matrixorigin/matrixone#29223 ·
-
needs-acceptance wg/data-plane-networking
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vllm-project/semantic-router#4024 · 1 comment ·