Exclude suite headings from the macOS test pass count

Open Beginner friendly
#342 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
macos, react-native
Domain
desktop, testing

Research direction

Start by inspecting the desktop test UI changed in PR #298 and compare its pass-count logic with the CLI report. Verify the result list handling with mixed suite headings, passing results, and failures; done means headings are excluded and the displayed count matches the CLI result.

Written by the indexing model from the issue text.

Description

The desktop test UI in PR #298 calculates passed tests by subtracting failures from all result entries. The result list also contains suite headings, so the displayed pass count is inflated.

Count only results whose type is correct, matching the CLI report. Verify mixed headings, passes, and failures.

Source: https://github.com/margelo/react-native-nitro-sqlite/pull/298

Dominant language
C
Stars
565
Forks
53
Avg merge
3d 13h
Merged PRs (30d)
28

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from margelo/react-native-nitro-sqlite

All issues in margelo/react-native-nitro-sqlite

Similar issues

More C issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.