marcospds/gulp-tasklist-run

Run method without done function parameter

Open

#6 opened on Sep 16, 2022

 (2 comments) (0 reactions) (0 assignees)JavaScript (3 forks)auto 404
beginnereasy pickgood first issuegulphacktoberfestjavascriptnpmtypescript

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

The method run receive done function, for finish the gulp task after run task list. Create a method run without done function parameter, allowed finish the gulp task before the list.

Actual:

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*', done)
})

//Starting 'e2e:*'...
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs
//Starting 'finish_e2e:*'...
//Finished 'finish_e2e:*' after 263 μs
//Finished 'e2e:*' after 2.7 ms

Expected:

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*', done)
})

//Starting 'e2e:*'...
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs
//Starting 'finish_e2e:*'...
//Finished 'finish_e2e:*' after 263 μs
//Finished 'e2e:*' after 2.7 ms

Or

gulp.task('e2e:*', (done) => {
  TaskListRun.run(gulp, 'e2e:*', 'e2e:\\*')
  done()
})

//Starting 'e2e:*'...
//Finished 'e2e:*' after 722 μs
//Starting 'e2e:login'...
//It works e2e:login!
//Finished 'e2e:login' after 745 μs
//Starting 'e2e:demo'...
//It works e2e:demo!
//Finished 'e2e:demo' after 339 μs

Contributor guide