maptalks/maptalks.js

Shared WebGL context

Open

#878 opened on Mar 11, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (495 forks)batch import
good first issue

Repository metrics

Stars
 (4,127 stars)
PR merge metrics
 (Avg merge 1d 7h) (10 merged PRs in 30d)

Description

maptalks's version and what browser you use? v0.43.0, chrome

Issue description Layers do not share WebGL context, which creates glitches when a map has more than one 3d layer. For example a buildings layer with a 3D line will not hide the line behind the buildings. In particular, I am implementing a 3D terrain layer but this layer will not hide (behind mountains) any other 3d element in the map, such as buildings.

Please provide a reproduction URL (on any jsfiddle like site) The following example fraws two vector layers. Due to the WebGL context not being shared, the rendering is wrong. http://jsfiddle.net/h6z5jtky/2/

Contributor guide

Research direction
Investigate how WebGL contexts are created and shared in maptalks.js. Look at the layer rendering pipeline and identify where contexts are initialized. The reproduction URL provides a test case to verify the issue.
Tech stack
javascript
Domain
web devcomputer graphics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60