maplibre/martin

Add more validations to .mbtiles detection

Open

#741 opened on Jul 3, 2023

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Rust (377 forks)auto 404
good first issuehelp wantedmbtilesrust

Repository metrics

Stars
 (3,761 stars)
PR merge metrics
 (PR metrics pending)

Description

As part of mbtiles type detection, we should catch some common issues:

  • detect if tiles (simple) or map (deduplicated) tables have an index by z,x,y columns
  • ???

In case of a problem, use a warn! macro to print a warning, unless we are certain the issue makes it impossible to use a file, in which case it should be appropriate error (add it to the error enum).

A bigger discussion is if mbtiles should stop using logging, and return some Vec<MbtilesWarning> if non-critical issues are detected.

Contributor guide

Research direction
Examine the detection code in mbtiles.rs, add checks for index presence on z,x,y columns in tiles or map tables. Use warn! for warnings, error for fatal issues. Consider alternative return type for warnings.
Tech stack
rust
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75