Unify special cases for reference/recursive_wrapper

Open
#83 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
tooling

Research direction

Start by locating the special handling for std::reference_wrapper and recursive_wrapper in get() and in the unwrapper helper used by the visitor apply functions. Compare the two paths and identify a shared place for that handling; done means both get() and apply_visitor() use the unified behavior without changing their existing results.

Written by the indexing model from the issue text.

Description

There are special cases for std::reference_wrapper and recursive_wrapper in two places. One is in the get() call, the other in unwrapper helper class used by the visitor apply functions. This looks to me like there should be a way to unify this code, so that there is only once place that has the special code used by get() and apply_visitor().

Dominant language
C++
Stars
384
Forks
96
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/variant

All issues in mapbox/variant

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.