Default parameters
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with include/shelf-pack.hpp lines 36-42 and trace how Bin's default x and y values are interpreted. Determine whether -1 is an intentional sentinel or whether 0 matches the surrounding API expectations. Done requires a maintainer-approved decision and an update to the declaration if the default should change.
Written by the indexing model from the issue text.
Description
I'm wondering why the parameters for Bin are set to default to -1, in particular for x and y. Would a better default be 0?
/cc @bhousel
- Dominant language
- C++
- Stars
- 16
- Forks
- 13
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/shelf-pack-cpp
-
Docs Open
Difficulty 5/5 Over a week Newbie friendliness 25/100
mapbox/shelf-pack-cpp#9 · 1 comment ·
All issues in mapbox/shelf-pack-cpp
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
AXERA-TECH/ax-llm#77 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
games-on-whales/wolf#509 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
bug-unconfirmed
Difficulty 2/5 1-3 hours Newbie friendliness 76/100