support for HiDPI
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- backend
Research direction
Start by reproducing the behavior with the provided config.json and the /toner and /toner-http @2x URLs. Compare the module with the modifications proposed in the linked node-tilejson pull request. Done means the /toner/6/11/26@2x.png endpoint returns the expected 512x512 image rather than 256x256.
Written by the indexing model from the issue text.
Description
The module doesn't seem to works with HiDPI screens like Retina.
Example:
save following under config.json, then run /usr/bin/nodejs /usr/bin/tessera -c . -p 28089
{
"/toner": {
"source": "tilejson+http://staging.tile.stamen.com/toner-background/index.json"
},
"/toner-http": {
"source": "http://toner-elb-3vaew2i23b6d-1666871272.us-east-1.elb.amazonaws.com/toner-background/{z}/{x}/{y}.png"
}
}
http://127.0.0.1:28089/toner-http/6/11/26@2x.png returns a 512x512 image. Fine.
http://toner-elb-3vaew2i23b6d-1666871272.us-east-1.elb.amazonaws.com/toner-background/6/11/26@2x.png returns a 512x512 image (it's the link described in the tilejson file). Fine.
http://127.0.0.1:28089/toner/6/11/26@2x.png returns a 256x256 image. Wrong :-(.
The solution is probably as simple as integrating the modifications proposed in https://github.com/mapbox/node-tilejson/pull/26/files.
- Dominant language
- JavaScript
- Stars
- 33
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/node-tilejson
-
mapbox/node-tilejson#54 · 1 assignee ·
-
README Open
Difficulty 4/5 3-5 days Newbie friendliness 15/100
mapbox/node-tilejson#38 · 1 comment ·
All issues in mapbox/node-tilejson
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·