binary host mirror override does not work for module_names with multiple dashes

Open Beginner friendly
#896 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript, node.js
Domain
tooling

Research direction

Start at lib/util/versioning.js around line 315 and compare the binary host mirror environment-variable handling with the reported module_name case in confluent-kafka-javascript/package.json. Confirm that a module name containing multiple dashes produces the expected mirror override, then run the repository's relevant tests or test suite to verify the behavior.

Written by the indexing model from the issue text.

Description

The binary host mirror environment variable does not work for packages with binary.module_name values containing more than one dash because it does not use replaceAll here: https://github.com/mapbox/node-pre-gyp/blob/master/lib/util/versioning.js#L315. I encountered this trying to use the binary host mirror override with https://github.com/confluentinc/confluent-kafka-javascript/blob/master/package.json#L19.

Dominant language
JavaScript
Stars
1.2k
Forks
271
Avg merge
23h 40m
Merged PRs (30d)
2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/node-pre-gyp

All issues in mapbox/node-pre-gyp

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.