mapbox/node-cpp-skel

Add make testpack

Open

#113 opened on Mar 22, 2018

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (9 forks)auto 404
good first issue

Repository metrics

Stars
 (74 stars)
PR merge metrics
 (PR metrics pending)

Description

Per convo with @flippmoke, I learned about make testpack which is used in node-mapnik to ensure the final package looks good to officially publish and to avoid dependency issues later in the chain.

Would be great for skel to have a workflow in place for ensuring the final package contains everything we'd expect, for example node_modules/node-pre-gyp/

cc @springmeyer @millzpaugh @mapsam

Contributor guide

Research direction
Inspect the node mapnik Makefile to understand the 'make testpack' target, then adapt it to node cpp skel and consider adding a CI workflow to verify the package contents.
Tech stack
cppnodejsshell
Domain
build system
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.jsMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80