Make allow text and icon overlap true by default

Open
#1,154 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
android, java
Domain
mobile

Research direction

Start by locating the implementation of symbolManager.setIconAllowOverlap(true) and symbolManager.setTextAllowOverlap(true), then inspect how their default values are defined. Change both defaults so end-user-added symbols allow overlap without explicit calls, and verify that style labels and icons retain their intended behavior. This is a breaking change requiring a semver major update.

Written by the indexing model from the issue text.

Description

Having the default value false, has led to confusion for our end users. The default value of false makes sense for symbols used in the style as labels and icons but for end-user added symbols, which are always important, we should not hide them by default. This is a breaking change and requires a semver major update.

          symbolManager.setIconAllowOverlap(true);
          symbolManager.setTextAllowOverlap(true);
Dominant language
Java
Stars
242
Forks
116
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/mapbox-plugins-android

All issues in mapbox/mapbox-plugins-android

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.