Should `MarkerViewManager` implement a more 'reactive' camera listener ?
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start by locating MarkerViewManager and its MapView.OnCameraDidChangeListener implementation, then compare its behavior with the camera listeners mentioned in the report. Reproduce the sluggish marker repositioning with the linked React Native and Lottie setup; done means smoother updates without an unacceptable GPU cost.
Written by the indexing model from the issue text.
Description
Hello,
The MarkerViewManager implements the MapView.OnCameraDidChangeListener so updating a MarkerView is only updated after the camera did change, and not while the camera is changing.
The consequence of that is some sluggish MarkerView re-positioning after a camera move, as shown here:
I tried replacing MapView.OnCameraDidChangeListener by MapView.OnCameraIsChangeingListener and had no more updates ?!
I then tried using MapboxMap.OnCameraMoveListener with better results:
https://imgur.com/ZNweZfQ
GPU usage is a tad high, that's why I'm not sending a PR.
Should MarkerViewManager implements a more 'reactive' camera listener ?
PS: on the above gifs, I'm using react-native with:
- https://github.com/react-native-mapbox-gl/maps
- and https://github.com/react-native-community/lottie-react-native for the animated orange markers
- Dominant language
- Java
- Stars
- 242
- Forks
- 116
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from mapbox/mapbox-plugins-android
-
Difficulty 3/5 1-2 days Newbie friendliness 30/100
mapbox/mapbox-plugins-android#1207 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
mapbox/mapbox-plugins-android#1206 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
mapbox/mapbox-plugins-android#1203 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
mapbox/mapbox-plugins-android#1195 · 1 comment · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
mapbox/mapbox-plugins-android#1193 · 1 comment ·
All issues in mapbox/mapbox-plugins-android
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
elastic/gradle-plugins#157 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cryptomator/hub#497 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
johanhaleby/occurrent#1120 ·