Consolidate route options tests

Open
#1,286 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
java
Domain
testing

Research direction

Start with the two identical resources: services-directions/src/test/resources/route_options_v5.json and services-directions-models/src/test/resources/route_options_v5.json. Check how tests in both modules locate the fixture, then consolidate the files so both test suites still run while only one copy requires maintenance.

Written by the indexing model from the issue text.

Description

jira-sync-complete Test

We currently have
https://github.com/mapbox/mapbox-java/blob/main/services-directions/src/test/resources/route_options_v5.json
and
https://github.com/mapbox/mapbox-java/blob/main/services-directions-models/src/test/resources/route_options_v5.json

which are identical and need to be maintained at the same time to run tests in 2 different modules. We need to consolidate the files to make maintenance easier.

Dominant language
Java
Stars
438
Forks
117
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mapbox/mapbox-java

All issues in mapbox/mapbox-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.