mapbox/mapbox-gl-js

v1.10.0-beta.1 - No way to disable new "tap then drag" to zoom gesture

Open

#9,584 opened on Apr 17, 2020

View on GitHub
 (1 comment) (4 reactions) (1 assignee)JavaScript (10,532 stars) (2,203 forks)batch import
feature :green_apple:good first issue

Description

The TouchZoomRotateHandler support various gestures ("zoom rotate", "pinch zoom/touch zoom", "single finger zoom/tap then drag"), however it only allows you to disable the "zoom rotate" gesture.

The individual gestures can be disabled by diving in to the private members (such as by calling "map.touchZoomRotate._tapDragZoom.disable();").

It would be nicer to have a match for disableRotation()/enableRotation() to turn on/off each supported gesture (i.e. add a disableTapZoom()/enableTapZoom()).

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with Mapbox GL JS APIUnderstanding of gesture handling in WebGL maps
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the existing TouchZoomRotateHandler to understand how disableRotation/enableRotation are implemented. Look at the private tapDragZoom property and its disable/enable methods. Consider adding similar public methods disableTapZoom/enableTapZoom following the same pattern. Check for any ongoing discussions in the issue comments or related PRs.